fix(browse): clean stale SingletonLock in handoff() before relaunch#2311
Open
jasonm-max wants to merge 1 commit into
Open
fix(browse): clean stale SingletonLock in handoff() before relaunch#2311jasonm-max wants to merge 1 commit into
jasonm-max wants to merge 1 commit into
Conversation
handoff() hand-rolled its own chromium-profile path and skipped the stale-lock cleanup that launchHeaded() already does. A prior hard-killed/crashed headed session leaves SingletonLock/Socket/Cookie pointing at a dead PID; Chromium's ProcessSingleton then silently hands startup off to the dead process instead of launching cleanly, and the new process exits within seconds — read as a clean disconnect, taking the whole daemon down with it. Now uses resolveChromiumProfile() + cleanSingletonLocks(), matching launchHeaded(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handoff()hand-rolled its ownchromium-profilepath and skipped the stale-lock cleanup thatlaunchHeaded()already does viaresolveChromiumProfile()+cleanSingletonLocks().SingletonLock/SingletonSocket/SingletonCookiepointing at a dead PID. Chromium'sProcessSingletonthen silently hands startup off to the dead/zombie process instead of launching cleanly, and the new process exits within seconds — Playwright reads that as a clean disconnect and takes the whole daemon down with it.handoff()now callsresolveChromiumProfile()+cleanSingletonLocks(), matching the existing pattern inlaunchHeaded().Test plan
handoff→ login → subsequent commands survive without the daemon dying, after the fixbun build --compile browse/src/cli.ts --outfile browse/dist/browsecompiles clean🤖 Generated with Claude Code